Re: ORBit_copy_value_core() bug?

[Michael Haubenwallner <michael haubenwallner salomon at>]

On Wed, 2007-12-12 at 14:44 +0100, Jules Colding wrote:
> Hi,
> 
> I might just be suffering from coffee deficiency but shouldn't the copy
> of sequences and arrays be walking the sequence/array members?
> 
> 
> Thanks,
>   jules
> 
> 
> 
> Index: corba-any.c
> ===================================================================
> --- corba-any.c	(revision 2040)
> +++ corba-any.c	(working copy)
> @@ -934,13 +934,13 @@
>  		pval1 = ((CORBA_Principal *)*val)->_buffer;
>  	
>  		for (i = 0; i < ((CORBA_Principal *)*newval)->_length; i++)
> -			ORBit_copy_value_core (&pval1, &pval2, tc->subtypes [0]);
> +			ORBit_copy_value_core (&pval1[i], &pval2[i], tc->subtypes [0]);

AFAICT ORBit_copy_value_core() increments both 'pval' and 'pval2' by
sizeof(CORBA_type), so subsequent call operates on next array element.
Additionally, compiler would index _bytes_ here, not _types_.

/haubi/


-- 
19. - 21. Februar 2008
Salomon Automation auf der LogiMAT 2008, Neue Messe Stuttgart, Deutschland
Halle 6, Stand 527

23. - 27. Februar 2008
MoveRetail auf der EuroShop 2008 in Düsseldorf, Deutschland
Halle 6, Stand C50





Salomon Automation GmbH - Friesachstrasse 15 - A-8114 Friesach bei Graz
Sitz der Gesellschaft: Friesach bei Graz
UID-NR:ATU28654300 - Firmenbuchnummer: 49324 K
Firmenbuchgericht: Landesgericht für Zivilrechtssachen Graz