Re: [PATCH] Timeout support - Please review
- From: Jules Colding <colding omesc com>
- To: "Gustavo J. A. M. Carneiro" <gjc inescporto pt>
- Cc: ORBit2 <orbit-list gnome org>
- Subject: Re: [PATCH] Timeout support - Please review
- Date: Tue, 05 Dec 2006 11:56:21 +0100
On Tue, 2006-12-05 at 10:47 +0000, Gustavo J. A. M. Carneiro wrote:
> On Ter, 2006-12-05 at 09:50 +0100, Jules Colding wrote:
> > On Mon, 2006-12-04 at 14:22 +0100, Jules Colding wrote:
> > > Please review and test this patch. I'm not entirely convinced that I
> > > haven't introduced a bad bug or two but at least it works(*) here.
> >
> > No responses yet, so it seems that my patch is of the usual flawless
> > quality ;-)
>
> Heh :)
>
> In fact, the patch sounds really nice, a sign of ORBit2 maturing for
> TCP/IP connections (which is traditionally seldom tested).
>
> My only comment is that the changelog entry could use a bit more
> detail. You only mention changes in one function, but the patch changes
> 4 functions and even adds a new commandline option which deserves a
> mention in the changelog too.
OK, I'll expand the ChangeLog and resend the patch :-)
Best regards,
jules
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]