Re: TypeCode operations

[Michael Meeks <michael ximian com>]

Hi Sam,

On Sun, 2002-02-24 at 04:49, Sam Couter wrote:
> Okay, I copied the TypeCode operations from ORBit STABLE, and apart from
> having to modify CORBA_TypeCode_member_label(), everything seems okay.

	Great.

> First, I'd like someone to check the included code to see that I'm
> generating the CORBA_any correctly, and not causing any memory leaks or
> other errors.

	The CORBA_any manipulation stuff looks just fine.

 I'm specifically worried about the call to
> ORBit_RootObject_duplicate() to copy the TypeCode for the CORBA_any, and
> the assumption that the caller owns the returned CORBA_any. If these two
> things are correct, then I'm confident that the code is right.

	They are correct.

> Second, someone in charge needs to tell me if these TypeCode operations
> are wanted on the HEAD branch, or if I should restrict them to the cpp
> branch.

	I think we should work on the cpp branch and merge that to HEAD when we
branch ORBit2 for Gnome 2.0.0, sadly it seems we'll have to wait until
2.0.1 or somesuch for your work to get exposed.

> Also, I've noticed that the tests don't include tests for any of these
> TypeCode operations, just for CORBA_TypeCode_equal() and
> CORBA_TypeCode_equivalent(). Should tests for these be added?

	Woah - yes, lots and lots of regression tests are good in
test/everything.

	Thanks & good work,

		Michael.

-- 
 mmeeks@gnu.org  <><, Pseudo Engineer, itinerant idiot