[PATCH] Re: ORBit warning

[Maciej Stachowiak <mjs eazel com>]

Elliot Lee <sopwith redhat com> writes:

> 
> etherealizing objects is basically killing all the servants that have been
> created on demand to service requests.
> 
> I think it is probably safe to pass FALSE in.

OK, in that case, here's a patch to Bonobo to silence this
warning. Michael, Miguel, is this OK to check in?

It fixes this Nautilus bug assigned to me:

http://bugzilla.eazel.com/show_bug.cgi?id=5796

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/bonobo/ChangeLog,v
retrieving revision 1.928
diff -u -p -r1.928 ChangeLog
--- ChangeLog	2001/01/30 14:49:55	1.928
+++ ChangeLog	2001/02/02 03:19:07
@@ -1,3 +1,12 @@
+2001-02-01  Maciej Stachowiak  <mjs eazel com>
+
+	* bonobo/bonobo-transient.c (bonobo_transient_destroy): pass FALSE
+	rather than TRUE for etherealize_objects since ORBit does not
+	implement the TRUE case anyway, and Elliot says passing FALSE is
+	safe. This fixes bugzilla.eazel.com bug 5796 (ORBit-WARNING **:
+	PortableServer_POA_destroy received after closing file manager
+	window)
+
 2001-01-30  Dietmar Maurer  <dietmar ximian com>
 
 	* bonobo/bonobo-arg.c (bonobo_arg_new): use the DynAny interface.
Index: bonobo/bonobo-transient.c
===================================================================
RCS file: /cvs/gnome/bonobo/bonobo/bonobo-transient.c,v
retrieving revision 1.12
diff -u -p -r1.12 bonobo-transient.c
--- bonobo/bonobo-transient.c	2001/01/18 18:23:28	1.12
+++ bonobo/bonobo-transient.c	2001/02/02 03:19:07
@@ -442,7 +442,7 @@ bonobo_transient_destroy (GtkObject *obj
 
 		/* Destroy the POA. */
 		CORBA_exception_init (&ev);
-		PortableServer_POA_destroy (transient->priv->poa, TRUE, TRUE, &ev);
+		PortableServer_POA_destroy (transient->priv->poa, FALSE, TRUE, &ev);
 
 		if (BONOBO_EX (&ev))
 			g_warning ("bonobo_transient_destroy: Could not destroy POA.");