r7167 - dumbhippo/trunk/server/src/com/dumbhippo/dm/fetch

[commits mugshot org]

Author: otaylor
Date: 2008-01-09 16:53:17 -0600 (Wed, 09 Jan 2008)
New Revision: 7167

Modified:
   dumbhippo/trunk/server/src/com/dumbhippo/dm/fetch/BoundFetch.java
Log:
Minor comment tweaks

Modified: dumbhippo/trunk/server/src/com/dumbhippo/dm/fetch/BoundFetch.java
===================================================================
--- dumbhippo/trunk/server/src/com/dumbhippo/dm/fetch/BoundFetch.java	2008-01-09 22:44:07 UTC (rev 7166)
+++ dumbhippo/trunk/server/src/com/dumbhippo/dm/fetch/BoundFetch.java	2008-01-09 22:53:17 UTC (rev 7167)
@@ -190,14 +190,18 @@
 		//
 		//  * Expand '+' to '+;<property1> <property1 children>;<property2> ....'
 		//    saves round trips at the expense of protocol efficiency, since the
-		//    client can know to short-circuit a later request for property1.
+		//    client can know to short-circuit a later request for '<property1>'.
 		//
 		//  * Add a '*' if all properties are fetched, to let the client know
 		//    that fetches for additional properties will not succeed.
 		//
 		//  * Omit properties from the fetch string that were previously sent.
 		//    even if they are explicitly requested again. (We already do this
-		//    for property *values*, just not in the fetch string.)
+		//    for property *values*, just not in the fetch string.) Compacts
+		//    the protocol a bit.
+		//
+		// But for the case where most of our traffic is requests for '+',
+		// this simple approach works fine.
 		// 
 		String fetchString = needFetch ? unboundFetch.toString() : null;
 		visitor.beginResource(classHolder, object.getKey(), fetchString, indirect);