Re: [PATCH] Fix static set of initial applications

On Mon, 2008-04-14 at 13:29 +0200, Marco Pesenti Gritti wrote:
> Looks like the code was moved from AppsStock to AppsRepo but these
> constants was forgot.

This looks fine, certainly.  As we were just discussing on IRC, my
inclination is we need to rethink this "statification" thing. 

 - It makes it very hard to explain how the apps stocks works
   ("it shows apps that were popular in the first 3 days you were
   using the online desktop"?)
 - It breaks if anybody pins something before that magic 3 days.
   Then they just get whatever they pinned?
 - I think it makes it unclear what pinning is about, since we
   co-opted it for our own usage.

My feeling is we should keep it simple and display:

 - all your pinned apps, followed by:
 - enough other apps to fill up the configured size of the apps stock.
   Where the other apps come from:
   - Your top applications (I think it's OK to start doing this as
     soon as you have top applications at all, sure it won't be that
     stable for the first couple of days, but that's OK)
   - Global top apps if you don't have enough top applications or
     app tracking is not enabled.
   - Local applications if you aren't logged in

[ Is that simple? Well, simpler than what we have now ... ]

> I gave a quick try to pylint on the code base and I found other
> similar problems. It would be useful to do it more systematically,
> except pygobject causes too many false positives. Someone on the Sugar
> team is working on that.

Yeah, certainly would be nice to have. Feel free to go ahead and
commit fixes for what you found.

- Owen

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]