r6973 - online-desktop/trunk/pyddm/ddm

[commits mugshot org]

Author: hp
Date: 2007-12-05 15:23:49 -0600 (Wed, 05 Dec 2007)
New Revision: 6973

Modified:
   online-desktop/trunk/pyddm/ddm/DataModel.py
Log:
should not ask for fallbackUserPhotoUrl in pyddm

Modified: online-desktop/trunk/pyddm/ddm/DataModel.py
===================================================================
--- online-desktop/trunk/pyddm/ddm/DataModel.py	2007-12-05 20:46:40 UTC (rev 6972)
+++ online-desktop/trunk/pyddm/ddm/DataModel.py	2007-12-05 21:23:49 UTC (rev 6973)
@@ -108,11 +108,9 @@
 
         _logger.debug("Doing initial query")
         
-        ## FIXME it's kind of random and broken to have this list of properties here... 
-        ## surely the only defensible list to have in a generic data model library 
-        ## would be "+" - i.e. why have a list of defaults here, and also have 
-        ## the concept of server-side defaults with "+"
-        query = self.query_resource("online-desktop:/o/global", "self +;webBaseUrl;online;ddmProtocolVersion;fallbackUserPhotoUrl")
+        # don't add global object properties you need here unless pyddm needs them - 
+        # instead, put another query in your app
+        query = self.query_resource("online-desktop:/o/global", "self +;webBaseUrl;online;ddmProtocolVersion")
         query.add_handler(self.__on_initial_query_success)
         query.add_error_handler(self.__on_initial_query_error)
         query.execute()