On Tue, 2007-12-04 at 17:47 -0600, commits mugshot org wrote:
> Modified: online-desktop/trunk/pyddm/ddm/DataModel.py
> ===================================================================
> --- online-desktop/trunk/pyddm/ddm/DataModel.py 2007-12-04 23:46:37 UTC (rev 6963)
> +++ online-desktop/trunk/pyddm/ddm/DataModel.py 2007-12-04 23:47:15 UTC (rev 6964)
> @@ -107,8 +107,12 @@
> self._reset()
>
> _logger.debug("Doing initial query")
> -
> - query = self.query_resource("online-desktop:/o/global", "self +;webBaseUrl;online;ddmProtocolVersion")
> +
> + ## FIXME it's kind of random and broken to have this list of properties here...
> + ## surely the only defensible list to have in a generic data model library
> + ## would be "+" - i.e. why have a list of defaults here, and also have
> + ## the concept of server-side defaults with "+"
> + query = self.query_resource("online-desktop:/o/global", "self +;webBaseUrl;online;ddmProtocolVersion;fallbackUserPhotoUrl")
> query.add_handler(self.__on_initial_query_success)
> query.add_error_handler(self.__on_initial_query_error)
> query.execute()
I don't think that fallbackUserPhotoUrl is even appropriately
defaultFetched. You just need to ask for it where you use it.
Everything that was there before is arguably something that is generic
to the data model, and not particular to the usage of the data model.
(webBaseUrl is maybe a bit questionable)
So, there are two separate things here:
A) "What's the role of default fetching" ... maybe a FIXME, but not
immediately urgent
B) Don't stick bigboard-specific stuff into pyddm. Please.
- Owen
(Also, terminology: don't say "server" when you mean data model engine.
The global resource is a property of the data model engine.)
Attachment:
signature.asc
Description: This is a digitally signed message part