[gnome-love] patch for bug#77194



This is one of the easy bugs mentioned by Glynn Foster.

    Steps to reproduce the problem
    ================================
    1. Start up System log viewer from menu (or invoke from command
    prompt)
    2. Press Ctrl + C key on the keyboard  --->  Calendar is displayed.
    3. Press 'Esc' key to close the calendar.
    
      But this doesn't work as there is no other way (except click 'x')
    to 
    close this application. Hence, application 'sys-log-viewer' should
    handle 
    this.
    

I don't think ESC is an appropriate way to close a window. Therefore,
I add a "Close" button and set it in focus by default. Either spacebar
or enter key can close the calendar window now. You don't even need to
reach for ESC:-)

Also, I think such a calendar window should be unresizable.

Here is the patch:
Index: calendar.c
===================================================================
RCS file: /cvs/gnome/gnome-utils/logview/calendar.c,v
retrieving revision 1.5
diff -r1.5 calendar.c
102a103
   GtkWidget *button;
120a122
      gtk_window_set_resizable (GTK_WINDOW (CalendarDialog), FALSE);
132a135,140
      button = gtk_button_new_with_label ("Close");
      g_signal_connect (G_OBJECT (button), "clicked",
GTK_SIGNAL_FUNC (close_calendar), &CalendarDialog);
      gtk_box_pack_end (GTK_BOX (vbox), button, TRUE, TRUE, 0);
      gtk_widget_grab_focus (GTK_BUTTON (button));
      gtk_widget_show (button);
      





        






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]