Re: [PATCH 0/2] add 2 new match filters to nm-settings

On Sat, 2020-03-07 at 11:47 +0100, Adrian Freihofer via networkmanager-
list wrote:
Basically it already seems to work. But I will test it further.
I'd like to know what, if anything, has to be changed for you to
accept it.

Usage example:



nice work! At first glance it also looks very good. Thank you.

This is exactly why the [match] setting was added: to add such features
like this.

The kernel-command-line sounds very reasonable to me.

About the driver, I guess it also makes sense. Often the driver comes
from udev, so an alternative would be to have more general matches for
udev attributes. But maybe that's unnecessary and overly complex, so
the simple match for driver might be best.

Since this is a larger patchset, maybe it would be more convenient to
discuss it as a merge-request on gitlab.


Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]