Re: [PATCH v2 3/7] wifi: add support for FILS

[Thomas Haller <thaller redhat com>]

On Sun, 2018-01-14 at 09:33 +0900, Masashi Honma wrote:
> The FILS(Fast Initial Link Setup) is a specification defined by IEEE
> 802.11ai to
> speed up roaming. This patch adds support of it.
>
> I have tested with these cases.
> +-----+-------------------------+----------------+
> > STA |            AP           |                |
> > FILS |         key-mgmt        |     result     |
>
> +-----+-------------------------+----------------+
> >  1  | WPA-EAP                 |       O        |
>
> +-----+-------------------------+----------------+
> >  1  | WPA-EAP-SHA256          |       O        |
>
> +-----+-------------------------+----------------+
> >  1  | FILS-SHA256             |       X        |
>
> +-----+-------------------------+----------------+
> >  1  | FILS-SHA384             |       X        |
>
> +-----+-------------------------+----------------+
> >  1  | WPA-EAP WPA-EAP-SHA256  |       O        |
> >     | FILS-SHA256 FILS-SHA384 | WPA-EAP-SHA256 |
>
> +-----+-------------------------+----------------+
> >  2  | WPA-EAP                 |       O        |
>
> +-----+-------------------------+----------------+
> >  2  | WPA-EAP-SHA256          |       O        |
>
> +-----+-------------------------+----------------+
> >  2  | FILS-SHA256             |       O        |
>
> +-----+-------------------------+----------------+
> >  2  | FILS-SHA384             |       O        |
>
> +-----+-------------------------+----------------+
> >  2  | WPA-EAP WPA-EAP-SHA256  |       O        |
> >     | FILS-SHA256 FILS-SHA384 | FILS-SHA384    |
>
> +-----+-------------------------+----------------+
> >  3  | WPA-EAP                 |       X        |
>
> +-----+-------------------------+----------------+
> >  3  | WPA-EAP-SHA256          |       X        |
>
> +-----+-------------------------+----------------+
> >  3  | FILS-SHA256             |       O        |
>
> +-----+-------------------------+----------------+
> >  3  | FILS-SHA384             |       O        |
>
> +-----+-------------------------+----------------+
> >  3  | WPA-EAP WPA-EAP-SHA256  |       O        |
> >     | FILS-SHA256 FILS-SHA384 | FILS-SHA384    |
>
> +-----+-------------------------+----------------+
>
> Signed-off-by: Masashi Honma <masashi honma gmail com>
> ---
>  libnm-core/nm-setting-wireless-security.c          | 57
> ++++++++++++++++++++++
>  libnm-core/nm-setting-wireless-security.h          | 26 ++++++++++
>  libnm/libnm.ver                                    |  2 +
>  man/NetworkManager.conf.xml                        |  5 ++
>  src/devices/wifi/nm-device-wifi.c                  | 18 +++++++
>  src/devices/wifi/nm-wifi-ap.c                      |  4 +-
>  .../plugins/ifcfg-rh/nms-ifcfg-rh-reader.c         |  7 +++
>  .../plugins/ifcfg-rh/nms-ifcfg-rh-writer.c         |  7 +++
>  src/supplicant/nm-supplicant-config.c              | 13 ++++-
>  src/supplicant/nm-supplicant-config.h              |  1 +
>  src/supplicant/nm-supplicant-settings-verify.c     |  1 +
>  src/supplicant/tests/test-supplicant-config.c      |  2 +
>  12 files changed, 141 insertions(+), 2 deletions(-)


You need to do
  cp ./clients/common/settings-docs.h \
     ./clients/common/settings-docs.h.in 

this is also complained by `make check` (depending on configure
options).




                                                            
>    "wifi-sec.fils",
> +                                                                 
>    NM_DEVICE (self));
> +                     fils = _nm_utils_ascii_str_to_int64 (value,
> 10,
> +                                                         NM_SETTI
> NG_WIRELESS_SECURITY_FILS_DISABLE,
> +                                                         NM_SETTI
> NG_WIRELESS_SECURITY_FILS_REQUIRED,
> +                                                         NM_SETTI

whitespace/indentation 



Thomas

Attachment: signature.asc
Description: This is a digitally signed message part