Re: [PATCH 1/2] ifcfg: test for sysconfig network path also on meson


On Fri, 2018-01-05 at 14:17 +0100, Iñigo Martínez wrote:
In a recent commit 1402fa7487b29fc1ea39a6bf7659fee7f30bb0e0 a new
way for testing Red Hat compatible distributions had been added.

This new testing approach has also been added to meson.
--- | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ b/
index cc704a47a..16195467a 100644
--- a/
+++ b/
@@ -207,8 +207,7 @@ glib_dep = declare_dependency(
 check_distro = join_paths(meson.source_root(), '') does "os.path.isfile(location)", hence it does not work
for /etc/sysconfig/network-scripts (which is a directory).

Also, how about moving to "tools/meson-test-file"?

Also, maybe use a shell script instead?
  for NAME; do
    test -e "$NAME" || exit 1

Also, wouldn't not something like
 if run_command('test', '-e', '/etc/sysconfig/network-scripts') == 0
be simpler?


Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]