Re: [PATCH 1.4 backport] device: cleanup setting of ip-iface



On Wed, 2017-01-11 at 20:05 -0600, Dan Williams wrote:
From: Thomas Haller <thaller redhat com>
Date: Mon, 26 Dec 2016 18:11:03 +0100

Move the updating/setting of the ip-ifindex/ip-iface to one place.

Properties should be for the most part immutable/read-only, and only
at particular places modified. That way, it's easier to track who
changes a property.

Also, add a logging line with "ip-ifname" prefix.

(cherry picked from commit 78017f1bdc300656bba2d45e079fd638d285e909)
---

Hi Dan,

I took the patch and merged it to nm-1-4:
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=c0fa787c2882d3db754faeecad3d4efbc6f5456d

I only changed to code-comment as it was no longer accurate. I did so,
by adding
 
+               *
+               * Backport: on master, we resolve the ifname anew via if_nametoindex().
+               *   For the backport, don't bother and look into the platform cache.


Thomas

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]