Re: [PATCH 1/2] Revert "shared/compat: fix memory handling of nm_setting_vpn_get_*_keys"

From: Thomas Haller <thaller redhat com>
To: "Jan Alexander Steffens (heftig)" <jan steffens gmail com>, networkmanager-list gnome org
Subject: Re: [PATCH 1/2] Revert "shared/compat: fix memory handling of nm_setting_vpn_get_*_keys"
Date: Fri, 22 Dec 2017 20:42:56 +0100

On Thu, 2017-12-21 at 20:36 +0100, Jan Alexander Steffens (heftig)
wrote:

This reverts commit 8ac8c01162235c2c198bfaf25fb7d1a57a595ce5.

The fix was bad because the keys do not come from NMSettingVpn's hash
table but are copies that are freed by nm_setting_vpn_foreach_*
before
it returns.



Hi,

Merged both patches + and follow up change of mine:
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=8
342a66cb6d8b7f19950370a83cc74bf6638a526


also copied to applet:
https://git.gnome.org/browse/network-manager-applet/commit/?id=a52ccb2f
e170558fc0aab4dd1d15ba8808b10951

hopefully it's finally correct!?! :)


Thanks,
Thomas

Attachment: signature.asc
Description: This is a digitally signed message part

References:
- [PATCH 1/2] Revert "shared/compat: fix memory handling of nm_setting_vpn_get_*_keys"
  - From: Jan Alexander Steffens (heftig)

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]