Re: [PATCH v3] Do not use /etc/resolv.conf symbolic links on SELinux

On Thu, 29/09/2016 at 17.52 +0200, Michael Biebl wrote:
Am 29.09.2016 um 17:33 schrieb Guido Trentalancia:

On Thu, 29/09/2016 at 17.29 +0200, Michael Biebl wrote:

Am 29.09.2016 um 17:11 schrieb Guido Trentalancia:

Run-time checks are wrong because they leave the filesystem in
state that is not usable when SELinux goes back into enforcing

Compile-time checks have no side effects and in any case are
than the bug!

Debian enables selinux support during compile time but we do not
selinux by default.

So the side-effect of this patch would be that suddenly NM would
files instead of symlinks on Debian.

This is not a side-effect in my opinion, but an added benefit
there is no good reason for using a symbolic link.

So you want to get rid of the symbolic link altogether and selinux is
only a diversion?

I am in favor of getting rid completely of the symbolic link creation,
but this is outside of the scope of a simple patch created as a quick
fix of an existing bug.

I'll leave more extensive changes to the author... They are not
strictly required for running NetworkManager.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]