Re: Auto-negotiation - Out of business

[poma <pomidorabelisima gmail com>]

On 23.11.2016 23:39, poma wrote:
> [...]
> Perhaps what is needed is to harmonise nm-connection-editor with changes in NM,
> i.e. not to apply ethernet 'duplex=full' by default.

Harmonises connection-editor with "changed the default value for auto-negotiate from TRUE to FALSE."
See https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=12b9d30

---
 src/connection-editor/page-ethernet.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/connection-editor/page-ethernet.c b/src/connection-editor/page-ethernet.c
index 307bfa9..9404dcb 100644
--- a/src/connection-editor/page-ethernet.c
+++ b/src/connection-editor/page-ethernet.c
@@ -446,7 +446,6 @@ ui_to_setting (CEPageEthernet *self)
                      NM_SETTING_WIRED_CLONED_MAC_ADDRESS, cloned_mac && *cloned_mac ? cloned_mac : NULL,
                      NM_SETTING_WIRED_PORT, port,
                      NM_SETTING_WIRED_SPEED, speed,
-                     NM_SETTING_WIRED_DUPLEX, gtk_toggle_button_get_active (priv->duplex) ? "full" : "half",
                      NM_SETTING_WIRED_AUTO_NEGOTIATE, gtk_toggle_button_get_active (priv->autonegotiate),
                      NM_SETTING_WIRED_WAKE_ON_LAN, wol,
                      NM_SETTING_WIRED_WAKE_ON_LAN_PASSWORD, wol_passwd && *wol_passwd ? wol_passwd : NULL,
-- 
2.7.4