Re: [PATCH v2 0/9] ofono/wwan modem support

[Dan Williams <dcbw redhat com>]

On Mon, 2016-06-13 at 18:51 +0200, Thomas Haller wrote:
> On Fri, 2016-06-10 at 17:56 -0400, Tony Espy wrote:
> > The following patches add ofono modem/wwan support
> > to NetworkManager.  These patches are based on the
> > latest stable 1.2.2 release.
> >
> > One caveat is that these patches have only been
> > tested using ofono's rilmodem driver ( as used by
> > Ubuntu Touch ), however other then the 'Preferred'
> > APN logic in the settings plugin, and the usage of
> > urfkill for flight-mode, the code should work with
> > other native ofono modem drivers as well.
> >
> > Didier Raboud (1):
> >   Check at runtime whether to start ModemManager
> >
> > Mathieu Trudel-Lapierre (4):
> >   Ignore rild modem devices.
> >   wwan: add support for using oFono as a modem manager
> >   Let NetworkManager read oFono settings file and create
> > connections
> >   Track killswitch change signals from urfkill
> >
> > Tony Espy (4):
> >   Add new NMSettingsConnection reset_retries get/set methods
> >   Add modem reconnect delay to policy
> >   Modify NMDeviceModem's available logic
> >   Fix ofono connection problems
>
> I rebased the 3 three patches to master and fixed some style issues
> and
> compiler warnings.
>
>
> Here: https://cgit.freedesktop.org/NetworkManager/NetworkManager/log/
> ?h=th/review/ofono

Cleanups look good so far, though we need to pkg-config check for
libsystemd-daemon instead of just HAVE_SYSTEMD.

Also we should rename NM_LINK_TYPE_WWAN_ETHERNET
to NM_LINK_TYPE_WWAN_NET and get the platform to recognize rmnet and
ccmni devices as this type.  Then the ignore stuff should work
correctly.  Ideally we can do this on the driver name instead of
matching the device name, but I'm not sure.  Neither of these drivers
are upstream yet, so we can't get them to do SET_NETDEV_DEVTYPE().

Dan