Re: [PATCH 8/9] Track killswitch change signals from urfkill

[Tony Espy <espy canonical com>]

On 06/08/2016 05:55 PM, Dan Williams wrote:
> On Wed, 2016-06-08 at 16:20 -0400, Tony Espy wrote:
> > From: Mathieu Trudel-Lapierre <mathieu trudel-lapierre canonical com>
> >
> > ... Also do that rather than resetting the killswitch to the NM saved
> > WirelessEnabled state if urfkill support is enabled.
> >
> > Gbp-Pq: Name Track-killswitch-change-signals-from-urfkill.patch
> > ---
> >   config.h.in              |   6 +
> >   configure.ac             |  11 ++
> >   src/Makefile.am          |   6 +
> >   src/nm-manager.c         | 112 +++++++++++++++++-
> >   src/nm-urfkill-manager.c | 289
> > +++++++++++++++++++++++++++++++++++++++++++++++
> >   src/nm-urfkill-manager.h |  50 ++++++++
> >   6 files changed, 472 insertions(+), 2 deletions(-)
> >   create mode 100644 src/nm-urfkill-manager.c
> >   create mode 100644 src/nm-urfkill-manager.h
> >
> > diff --git a/config.h.in b/config.h.in
> > index baabb79..356de31 100644
> > --- a/config.h.in
> > +++ b/config.h.in
> > @@ -261,6 +261,9 @@
> >   /* Define if you have ModemManager1 support */
> >   #undef WITH_MODEM_MANAGER_1
> >
> > +/* Define if you have oFono support */
> > +#undef WITH_OFONO
> > +
> >   /* whether to compile polkit support */
> >   #undef WITH_POLKIT
> >
> > @@ -276,6 +279,9 @@
> >   /* Define if you have Teamd control support */
> >   #undef WITH_TEAMDCTL
> >
> > +/* Define if you want to build with support for the urfkill daemon
> > */
> > +#undef WITH_URFKILL
> > +
> >   /* Define if you have Wi-Fi support */
> >   #undef WITH_WIFI
>
> This hunk wouldn't apply upstream since config.h.in gets auto-
> generated...  so can just be removed from the patch.

I removed this chunk, and also addressed all of your other comments 
except for the rfkill_change_timeout.  I pinged Mathieu earlier and 
asked him to comment on this.

Regards,
/tony