Re: [PATCH v2 5/5] Fixes to update PacRunner at the right moment.

On Tue, 2016-07-12 at 17:57 +0530, Atul Anand wrote:
src/: Fixes in core to update PacRunner at the right place and
When a device goes up PacRunner is configured with the Device
and Proxy Config. When it goes down the same configuration is removed
from PacRunner.

ifcfg-rh: Fixed to read and write proxy settings to the ifcfg network
 static gboolean
+write_proxy_setting (NMConnection *connection, shvarFile *ifcfg,
GError **error)
+     NMSettingProxy *s_proxy;
+     NMSettingProxyMethod method;
+     char *tmp;
+     const char *pac_url, *pac_script;
+     const char *http_proxy, *ssl_proxy, *ftp_proxy,
+     guint32 http_port, ssl_port, ftp_port, socks_port;
+     gboolean http_default, socks_version_5;
+     GString *no_proxy_for;
+     char **iter, **excludes = NULL;
+     s_proxy = nm_connection_get_setting_proxy (connection);
+     if (!s_proxy)
+             return FALSE;

You want to return TRUE here. It's alright not to have proxy settings
and when returning FALSE you need to set an error.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]