Re: [PATCH v2] dns: clean up error paths in dns-manager

[Dan Williams <dcbw redhat com>]

On Mon, 2016-01-25 at 22:59 +0100, Beniamino Galvani wrote:
> On Mon, Jan 25, 2016 at 12:59:22PM -0600, Dan Williams wrote:
> > From 2370f508df8400b424fec032f8314cea97fdbaef Mon Sep 17 00:00:00
> > 2001
> > From: Dan Williams <dcbw redhat com>
> > Date: Wed, 20 Jan 2016 13:52:59 -0600
> > Subject: [PATCH] dns: clean up error paths in dns-manager
> >
> > Specifically for resolvconf, if the write succeeded, but the
> > pclose()
> > failed error would be left NULL and SR_ERROR would be returned,
> > which
> > caused a crash in nm_dns_manager_end_updates().
> > ---
> > v2: fixed thaller's comments except for the '\n' which I'll do in
> > another patch
>
> Looks good to me.

Pushed along with the newline cleanup Thomas requested.

Dan