Re: [PATCH 1/1] platform: optimize sysctl_set() to use stack allocated buffer



On Tue, 2016-02-23 at 23:54 +0100, Thomas Haller wrote:
The value written to sysctl is usually a short string. It makes sense
to optimize for this case and avoid allocating a temporary string
on the heap.

An alternative would be to use writev(), which effectively does the
same
and also creates a temporary buffer (preferably stack allocated).
---
 src/platform/nm-linux-platform.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)


merged:
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=b913e1d641e98c99f27936d76828998ae5534fbb


Thomas

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]