Re: [PATCH] exported-object: set object path after skeleton creation

From: Thomas Haller <thaller redhat com>
To: Beniamino Galvani <bgalvani redhat com>, networkmanager-list gnome org
Subject: Re: [PATCH] exported-object: set object path after skeleton creation
Date: Thu, 11 Feb 2016 12:56:32 +0100

On Thu, 2016-02-11 at 11:58 +0100, Beniamino Galvani wrote:

When exporting an object, we first set the object path and then
create
GDBus interface skeletons. While doing this, a signal can be
generated
[1] and then nm_exported_object_signal_hook() can trigger the failed
assertion "interface != NULL" because the object is already exported
(priv->path != NULL) but the interface has not been registered yet.

To fix this, set the object path only after skeletons have been
created.


looks good to me.


Merged:
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=14c16a8b22ed53c40db2c14cb0e76da2c844917c


Thomas

Attachment: signature.asc
Description: This is a digitally signed message part

References:
- [PATCH] exported-object: set object path after skeleton creation
  - From: Beniamino Galvani

[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]