On Wed, 2016-12-07 at 16:35 -0600, Dan Williams wrote:
Introspection really doesn't depend on whether we're building setting docs. Split these two up. ---
Hi Dan, I don't really understand what the patch tries to achieve. Doesn't this basically revert commit https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=a80ba4ea09003672cc3070cd82f549ba64728866 ? To my understanding, your the commit message seems wrong. On current master introspection does precisely not depend on building-docs. That was the point of a80ba4ea090 To build nmcli, one needs the generated clients/cli/settings-docs.c. (at least since https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=104546cc211739dc2356d4a39d4ace2679812aff ) This file is disted, so building from a source-tarball works with "--enable-gtk-doc=no --enable-introspection=no" (good). Building from the git tree, the file needs to be generated first. For that, it needs at least "--enable-introspection=yes", (and additionally with introspection we need xslt, python, pygobject). So that means, when building from a git-tree, you can do --without-nmcli --enable-introspection=no or --with-nmcli --enable-introspection=yes Both works. Your patch breaks: ./configure --with-nmcli --enable-gtk-doc=no --enable-introspetion=yes (from a clean git-tree) best, Thomas
Attachment:
signature.asc
Description: This is a digitally signed message part