Re: [PATCH] connection-editor: Fix handling of wired 802-1x security setting



On Thu, 25 Aug 2016 20:46:01 +0300 Mikhail Efremov wrote:
Function nm_setting_duplicate() can't copy object's data.
As a result a value of the "Ignore CA certificate" checkbox was
always lost. So don't copy settings, just use g_object_ref() again
and remove the 8021x setting from the temporary object to prevent
the clearing of secrets.

Fixes: c21d56dd22057103c8125a49307b4ff47b5b644d

This patch based on commit 4eecd6409730b0e03b7cca0e21d2f7f35302965b
by Beniamino Galvani, which fixes the same issue. Definitely my
former patch in the commit c21d56dd22057103c8125a49307b4ff47b5b644d was
wrong. Dunno how I overlooked that state of the "Ignore CA certificate"
checkbox was not saved at the time...

-- 
WBR, Mikhail Efremov


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]