Re: [PATCH v4 1/7] libnm: API for Proxy Feature

[Dan Williams <dcbw redhat com>]

On Wed, 2016-08-17 at 22:36 +0200, Thomas Haller wrote:
> On Wed, 2016-08-17 at 10:33 -0500, Dan Williams wrote:
> > On Tue, 2016-08-16 at 23:38 +0200, Thomas Haller wrote:
> > > On Tue, 2016-08-16 at 05:55 +0530, Atul Anand wrote:
> > > > libnm-core has been expanded to include proxy settings which
> > > > clients
> > > > like nmcli, nm-connection-editor use to configure proxy in
> > > > PacRunner.
> > > > It
> > > > offers three modes i.e 'auto', 'manual'and 'none' and
> > > > accordingly
> > > > take
> > > > data to configure PacRunner. The modes matches on the PacRunner
> > > > side
> > > > too.
> > > Hi Atul,
> > >
> > >
> > > I took your v4 and pushed it to a branch (I find that easier to
> > > review).
> > >
> > > Thereby, I added several fixup commits and suggestions.
> > >
> > > Please ACK/NACK them.
> > >
> > > https://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h
> > > =t
> > > h/
> > > proxy
> > In one of the "fixup! src:(pacrunner-manager): Object for
> > interaction
> > with PacRunner" commits in pacrunner_proxy_cb(), there's this hunk:
> >
> >     proxy = g_dbus_proxy_new_for_bus_finish (res, &error);
> >     if (!proxy) {
> >             if (!g_error_matches (error, G_IO_ERROR,
> > G_IO_ERROR_CANCELLED))
> >                     _LOGW ("failed to connect to pacrunner via
> > DBus: %s", error->message);
> > -           g_clear_error (&error);
> > +           g_free (error);
> >             return;
> of course!! thanks!
>
> rebased and repushed.

After that change it looked OK to me...

Dan