Re: [PATCH v4 1/7] libnm: API for Proxy Feature

[Atul Anand <atulhjp gmail com>]

Follow-up fixes looks great so far.

Thanks,
Atul

On 8/17/16, Thomas Haller <thaller redhat com> wrote:
> On Tue, 2016-08-16 at 05:55 +0530, Atul Anand wrote:
> > libnm-core has been expanded to include proxy settings which clients
> > like nmcli, nm-connection-editor use to configure proxy in PacRunner.
> > It
> > offers three modes i.e 'auto', 'manual'and 'none' and accordingly
> > take
> > data to configure PacRunner. The modes matches on the PacRunner side
> > too.
>
> Hi Atul,
>
>
> I took your v4 and pushed it to a branch (I find that easier to
> review).
>
> Thereby, I added several fixup commits and suggestions.
>
> Please ACK/NACK them.
>
> https://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=th/proxy
>
> More to come.
>
>
>
> Thanks so far,
> Thomas