Re: [PATCH 1/1] start after systemd-networkd



Thomas Haller <thaller redhat com> on Wed, 2015/11/25 15:11:
On Wed, 2015-11-25 at 11:53 +0100, Christian Hess wrote:
From: Christian Hesse <mail eworm de>

It is possible to use systemd-networkd for some general network setup
(rename devices, ...) even for devices that are managed by
NetworkManager later.
Since systemd 228 the behaviour changed that systemd-networkd drops
foreign configuration from devices. It does not change configuration
that is done after systemd-networkd has started up, though.
To prevent race conditions we order NetworkManager service to start
after systemd-networkd service.  

The "After" will delay starting NetworkManager only "after networkd
declared to be started".

That's not true. From man 5 systemd.unit:

[...] while After= ensures that the configured unit is started after the
listed unit finished starting up [...]

That is not the same as "after networkd completed configuring the
network interfaces" -- which is what "networkd-wait-online.service"
might be.

This service can be activated in addition, but achieves something different:
It finished successful after a network connection is established, which is
different from starting the systemd-networkd service.

Because of that, I don't think this patch is correct.

I think it is. ;)
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}

Attachment: pgp3mK1WlwEtV.pgp
Description: OpenPGP digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]