Re: [PATCH 2/2] Added OpenSSL crypto backend

[Lubomir Rintel <lkundrak v3 sk>]

Hi Joel,

thanks for the patch but I don't think it makes sense to apply it. 

I think distributing NetworkManager linked with OpenSSL would be a
violation of NetworkManager's license (since the OpenSSL license adds
an extra restriction, something that is not allowed by General Public
License).

Please refer to the following link for more details and discussion on
the topic:

https://people.gnome.org/~markmc/openssl-and-the-gpl.html

We do already have two crypto backends whose license doesn't clash with
our licensing, I suggest you just use those if possible.

Sorry for that.

Lubo

On Thu, 2015-11-19 at 00:01 +0000, Joel Holdsworth wrote:
> ---
>  configure.ac                |  16 ++-
>  libnm-core/Makefile.am      |   6 +
>  libnm-core/crypto_openssl.c | 324
> ++++++++++++++++++++++++++++++++++++++++++++
>  po/POTFILES.in              |   1 +
>  4 files changed, 340 insertions(+), 7 deletions(-)
>  create mode 100644 libnm-core/crypto_openssl.c
>
> diff --git a/configure.ac b/configure.ac
> index 7b4ca9a..83ae5a0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -594,10 +594,12 @@ else
>  fi
>  AC_SUBST(NM_MODIFY_SYSTEM_POLICY)
>  
> -AC_ARG_WITH(crypto, AS_HELP_STRING([--with-crypto=nss|gnutls],
> [Cryptography library to use for certificate and key
> operations]),ac_crypto=$withval, ac_crypto=nss)
> +AC_ARG_WITH(crypto, AS_HELP_STRING([--with-
> crypto=nss|gnutls|openssl],
> +     [Cryptography library to use for certificate and key
> operations]), ac_crypto=$withval, ac_crypto=nss)
>