Re: dhcpcd support broken

[Dan Williams <dcbw redhat com>]

On Tue, 2015-05-26 at 17:49 +0000, Joakim Tjernlund wrote:
> On Tue, 2015-05-26 at 12:22 -0500, Dan Williams wrote:
> > On Mon, 2015-05-25 at 20:47 +0000, Joakim Tjernlund wrote:
> > > This commit seems have broken dhcpcd support:
> > > http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/configure.ac?h=nm-1
> > > -0&id=7daf63461de4195b1626ca15f835fc7cbc56e847
> > >
> > >
> > >  $ ./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu -
> > > -mandir=/usr/share/man -
> > > -infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable
> > > -dependency
> > > -tracking --disable-silent-rules --libdir=/usr/lib64 --docdir=/usr/share/doc/networkmanager-1.0.2 -
> > > -disable
> > > -maintainer-mode --disable-gtk-doc --disable-more-warnings --disable-static --localstatedir=/var 
> > > --disable
> > > -lto
> > > --disable-config-plugin-ibft --disable-ifnet --without-netconfig 
> > > --with-dbus-sys-dir=/etc/dbus-1/system.d 
> > > -
> > > -with-udev-dir=/lib/udev --with-config-plugins-default=keyfile --with-iptables=/sbin/iptables --with
> > > -libsoup=yes --enable-concheck --with-crypto=gnutls --with-session-tracking=consolekit --with-suspend
> > > -resume=upower --enable-bluez5-dun --enable-introspection --enable-ppp --disable-wimax 
> > > --without-dhclient 
> > > -
> > > -with-dhcpcd --without-modem-manager-1 --with-nmtui --with-resolvconf --without-selinux 
> > > --disable-teamdctl 
> > > -
> > > -disable-tests --enable-vala --without-valgrind --with-wext --with-pppd-plugin-dir=/usr/lib64/pppd/2.4.7
> > >
> > > ....
> > >
> > > configure:23483: checking for dhcpcd
> > > configure:23502: found /sbin/dhcpcd
> > > configure:23514: result: /sbin/dhcpcd
> > > configure:23528: WARNING: Cannot use dhcpcd, version 4.x or higher is required
> > > configure:23540: WARNING: Could not find a suitable DHCP client, falling back to dhclient
> >
> > It looks like that commit was wrong, because with the [[ and ]] the []
> > won't get carried through to configure itself.  Could you edit configure
> > and make the dhcpcd grep section look like:
> >
> >       if test "$with_dhcpcd" != "no"; then
> >               if ! $with_dhcpcd --version 2>&1 | grep -q "^dhcpcd [456789]\."; then
> >                       { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: Cannot use dhcpcd,
> > version 4.x or higher is required" >&5
> > $as_echo "$as_me: WARNING: Cannot use dhcpcd, version 4.x or higher is
> > required" >&2;}
> >                       with_dhcpcd=no
> >               elif $with_dhcpcd --version 2>&1 | grep -q "^dhcpcd [789]\."; then
> >
> > $as_echo "#define DHCPCD_SUPPORTS_IPV6 1" >>confdefs.h
> >
> >               fi
> >       fi
> >
> > and then rerun configure and see if that fixes things?
>
> It does fix things, although removing the 6 disables IPv6 support, keeping ^dhcpcd [6789]\."
> enables IPv6.

Yeah, that was my fault, it was a local modification for testing.

I've pushed the fix to nm-0-9-10, nm-1-0, and git master.

> I still want to point out that runtime test breaks cross compile(minor) and
> testing version for ipv6 is not enough(major) as dhcpcd can be built without ipv6 support

I suppose instead NM could exec "dhcpcd -V" and then look for the string
"DHCPv6 options:" in the output the first time dhcpcd is run.

Beniamino, could you look into that?

Dan