Re: [PATCH 1/2] warn if gtkdocize is missing, exit on error

Hi Dan,

Actually, gtkdoc isn't required for the build unless you want to do
'make dist' or distcheck.  So in theory, perhaps we should just warn
about that and continue, instead of erroring out?
That's what I intended when I wrote the patch. But depends on gtk-doc.make,
which is AFAIK symlink to /usr/share/gtk-doc/data/gtk-doc.make (on my Debian unstable) and
this file is from gtkdoc. So in my case without gtkdoc fails:
docs/api/ error: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
automake: error: cannot open < gtk-doc.make: No such file or directory
autoreconf: automake failed with exit status: 1

But adding ENABLE_GTK_DOC in AM_CONDITIONAL isn't enough. As code after including
gtk-doc.make expect some variables to be set. There are two options:

1) Cairo way: include gtk-doc.make somewhere and use it when missing. Cairo uses
instead of gtk-doc.make file They use it probably to fix some of
their problems, but this also helps to avoid this problem. I don't think it's a good
option (needs to synchronize file time to time).

2) Gimp way: create minimal gtk-doc.make file. This looks to me as a better
option, so I implement it and send as v2. --force option to autoreconf cause replacing
minimal gtk-doc.make with symlink to /usr/share/gtk-doc/data/gtk-doc.make once gtkdoc is


Kind regards,

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]