Re: [PATCH] build: install nm-settings-ifcfg-rh.5 man page conditionally

[Lubomir Rintel <lrintel redhat com>]

Hi Michael,

Thanks you for the patch.

On Mon, 2015-02-09 at 01:31 +0100, Michael Biebl wrote:
> Only install nm-settings-ifcfg-rh.5 man page if the ifcfg-rh
> configuration plugin has been enabled. It's confusing to have this man
> page around on e.g. a Debian based distro.
>
> See attached patch.
>
> There might be small issue here, i.e. if you build the release tarball
> and you don't have ifcfg-rh enabled, then the nm-settings-ifcfg-rh.5 man
> page would be missing from the release tarball as it's not added to
> EXTRA_DIST
>
> If that is a concern, please let me know and I'll rework to the patch to
> always unconditionally build and dist the man pages, but only install
> them conditionally.

The distribution tarball contents indeed should not depend on the
configuration configuration options. Please rework it the way you
suggest.

Thank you,
Lubo

(By the way, the preferred way to submit patches by e-mail is inline as
opposed to adding an attachment. git send-email makes that easy. Not a
big deal really, especially for small patches, but it makes it a bit
more convenient to quickly review and reply inline in some e-mail
clients.)