Re: review: th/nm_utils_hwaddr_ntoa_len



On Thu, 2014-05-29 at 17:15 -0500, Dan Williams wrote:
Since there's no bug for it yet...

core: refactor to use nm_utils_hwaddr_ntoa_len() instead of printf()

Instead of touching nm-device-bt.c, lets just make it super-simple, for
which I pushed a patch.  Although you probably want to rebase and move
the commit earlier and fixup, and then just not touch nm-device-bt.c in
this commit at all.

The rest looks great!

Dan


Thanks Dan,

I merged the branch as
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=00a6f9dcf9a6a244ca7ebc4b25ac2b1caa70817f

I took your commit as it was, only added a sentence to your commit
message. 


Thomas

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]