Re: [PATCH] Fix for segmentation fault on WiFi rescan

On 25/05/14 05:44 PM, Thomas Haller wrote:
On Sat, 2014-05-24 at 21:07 -0400, M. Vefa Bicakci wrote:

I am using an up-to-date version of Debian Sid with KDE 4.13.1. I noticed that
after Debian has upgraded NetworkManager from to, whenever I
click on the KDE network management widget's (plasma-nm) WiFi rescan button,
NetworkManager crashes with a segmentation fault.

After a debugging session, I found out that the crash occurs because commit
da59b6d2229b85afbb9e14846931376340dc6030 updated the arguments of the
device_auth_request_cb function to include a pointer to a NMConnection
structure, but the NM_DEVICE_AUTH_REQUEST signal emitted by the
impl_device_request_scan function does not include the required pointer.

This causes NetworkManager and later versions to crash every time a WiFi
rescan is initiated.

Please find attached a patch which fixes this issue.

(For the record, I do not know if I have solved the problem in an acceptable and
elegant manner: nm_device_get_connection returns NULL if we are not connected,
and we cannot verify the access control lists of a connection because we are not

Hi Vefa,

I applied your patch and commited it to nm-0.9.8 branch:

This bug was already fixed in master, but it was forgotten during
backporting. The fix on master is

Actually, I modified your patch to behave identical as d96534. I hope,
you are fine with the patch still carrying your name as author.

Thank you for your work tracking this down,

Hello Thomas,

I just wanted to thank you for the quick response and for applying the patch,
even if slightly modified.

Thanks again,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]