Re: [PATCH] core: fix auto-activation of ignore-carrier devices when carrier appears (rh #1076592)
- From: Dan Williams <dcbw redhat com>
- To: Thomas Haller <thaller redhat com>
- Cc: "networkmanager-list gnome org" <networkmanager-list gnome org>
- Subject: Re: [PATCH] core: fix auto-activation of ignore-carrier devices when carrier appears (rh #1076592)
- Date: Mon, 17 Mar 2014 10:35:34 -0500
On Mon, 2014-03-17 at 13:57 +0100, Thomas Haller wrote:
On Fri, 2014-03-14 at 15:26 -0500, Dan Williams wrote:
If a device had its carrier ignored, and did not have a carrier on startup,
then NetworkManager would not re-check autoconnect connections when the
device's carrier appeared. Because ignore-carrier devices are always
in DISCONNECTED state when they are managed, the nm-device.c::carrier_changed()
code essentially did nothing when the carrier appeared. It needs to
also trigger an auto-activation recheck signal when the carrier appears
to ensure that now-valid connections (like those that require DHCP or
IPv6) can be auto-activated.
---
Acked-by: Thomas Haller <thaller redhat com>
Pushed.
Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]