Re: [patch NetworkManager] ifcfg-rh reader: assume type for Team ports

[Dan Williams <dcbw redhat com>]

On Mon, 2014-03-10 at 13:07 +0100, Jiri Pirko wrote:
> Initscripts compatibility requires that if DEVICETYPE is set, TYPE shall
> not be set. So do something similar we already do for Team masters for
> Team ports.
>
> Signed-off-by: Jiri Pirko <jiri resnulli us>
> ---
>  src/settings/plugins/ifcfg-rh/reader.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/settings/plugins/ifcfg-rh/reader.c b/src/settings/plugins/ifcfg-rh/reader.c
> index ebf2975..dd9a3fe 100644
> --- a/src/settings/plugins/ifcfg-rh/reader.c
> +++ b/src/settings/plugins/ifcfg-rh/reader.c
> @@ -4999,6 +4999,8 @@ connection_from_file (const char *filename,
>       if (devtype) {
>               if (!strcasecmp (devtype, TYPE_TEAM))
>                       type = g_strdup (TYPE_TEAM);
> +             if (!strcasecmp (devtype, TYPE_TEAM_PORT) && !type)
> +                     type = g_strdup (TYPE_ETHERNET);
>               g_free (devtype);
>       }

Thanks!  As with the other one, this is being followed in Red Hat bug
1074160 and the jk/rh1074160-team-port branch, where Jirka has added
some testcases too.

Dan