Re: NetworkManager-openvpn-0.9.8.4 and gnome-keyring

[Dan Williams <dcbw redhat com>]

On Sat, 2014-06-28 at 10:37 +0000, John Frankish wrote:
> > > > > > > The configure script for NetworkManager-openvpn-0.9.8.4 looks
> > > > > > > for gnome-keyring-1.pc, which is not present in
> > > > > > > gnome-keyring-3.10.1
> > > > > > >
> > > > > > > Is this mean to be compiled with ''--without-gnome" for gnome-3?
> > > > > >
> > > > > > Which Linux distro do you have?  The development headers are
> > > > > > often shipped in sub-packages, like "gnome-keyring-devel" or
> > > > > > "gnome-keyring- dev".  It may also be named
> > > > > > "gnome-keyring-libs-devel" or "gnome-keyring- libs-dev".  Does your distro have any packages like 
> > > > > > that?
> > > > > I compiled Gnome-keyring-3.10.1 from source - it looks like the source package no longer installs 
> > > > > gnome-keyring-1.pc since about gnome-keyring- 3.4.x?
> > > > >
> > > > > The only libs installed are:
> > > > >
> > > > > /usr/local/lib/gnome-keyring/devel/gkm-gnome2-store-standalone.so
> > > > > /usr/local/lib/gnome-keyring/devel/gkm-secret-store-standalone.so
> > > > > /usr/local/lib/gnome-keyring/devel/gkm-ssh-store-standalone.so
> > > > > /usr/local/lib/gnome-keyring/devel/gkm-xdg-store-standalone.so
> > > > > /usr/local/lib/pkcs11/gnome-keyring-pkcs11.so
> > > > > /usr/local/lib/security/pam_gnome_keyring.so
> > > > >
> > > > > ..so perhaps this makes sense?
> > > >
> > > > I think I know the issue.  Upstream GNOME switched to "libsecret",
> > > > which network-manager-openvpn was not ported to use.  We'll have to
> > > > fix that in the NM-openvpn 0.9.8.x branch, it was already fixed in git master.
> > > >
> > > > So the short answer is it's not going to work right now, but should
> > > > soon.
> > >
> > > John, can you test the attached patch?  Let me know if this fixes the
> > > issue for you.  Thanks!
> >
> > The one where I forget to attach the patch.  Fixed.
>
> Thanks - the patch applies cleanly, but "make" fails as below.
>
> I tried substituting the libsecret CFLAGS and LIBS for @GNOMEKEYRING_CFLAGS@ and @GNOMEKEYRING_LIBS@, but 
> it didn't help.

Try re-running configure, there might be some generated files that need
updating after this patch.  Does that help?

Dan

> John
>
> ----------
>
> patch -Np1 -i ../0001-auth-dialog-port-to-libsecret.patch
>
> autoreconf -fi
>
> CC="gcc -flto -fuse-linker-plugin -mtune=generic -Os -pipe" CXX="g++ -flto -fuse-linker-plugin 
> -mtune=generic -Os -pipe -fno-exceptions -fno-rtti" ./configure --prefix=/usr/local --disable-static 
> --localstatedir=/var --libexecdir=/usr/local/lib/NetworkManager
>
> make
> ...
>
> make[2]: Entering directory `/usr/src/NetworkManager-openvpn-0.9.8.4/auth-dialog'
> gcc -flto -fuse-linker-plugin -mtune=generic -Os -pipe -DHAVE_CONFIG_H -I. -I..  -pthread 
> -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include  -pthread 
> -I/usr/local/include/gtk-3.0 -I/usr/local/include/at-spi2-atk/2.0 -I/usr/local/include/gtk-3.0 
> -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include -I/usr/local/include/cairo 
> -I/usr/local/include/pango-1.0 -I/usr/local/include/harfbuzz -I/usr/local/include/pango-1.0 
> -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include 
> -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include 
> -I/usr/local/include/libdrm -I/usr/local/include -I/usr/local/include/libpng16 -I/usr/local/include 
> -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/libpng16 -I/usr/local/include/glib-2.0 
> -I/usr/local/lib/glib-2.0/include -I/usr/local/include  -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_0 
> -I/usr/local/include/NetworkManager -I/usr/local/include/libnm-glib -I/usr/local/include/NetworkManager 
> -I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include -I/usr/local/include/glib-2.0 
> -I/usr/local/lib/glib-2.0/include -I/usr/local/include  @GNOMEKEYRING_CFLAGS@ -I../   -Wall -std=gnu89 -g   
> -Wshadow -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-after-statement -Wstrict-prototypes 
> -Wfloat-equal -Wno-unused-parameter -Wno-sign-compare -fno-strict-aliasing -Wno-unused-but-set-variable 
> -Werror -MT nm_openvpn_auth_dialog-main.o -MD -MP -MF .deps/nm_openvpn_auth_dialog-main.Tpo -c -o 
> nm_openvpn_auth_dialog-main.o `test -f 'main.c' || echo './'`main.c
> gcc: error: @GNOMEKEYRING_CFLAGS@: No such file or directory
> make[2]: *** [nm_openvpn_auth_dialog-main.o] Error 1
> make[2]: Leaving directory `/usr/src/NetworkManager-openvpn-0.9.8.4/auth-dialog'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/usr/src/NetworkManager-openvpn-0.9.8.4'
> make: *** [all] Error 2