Re: [PATCH] core: log when removing devices

[Dan Winship <danw gnome org>]

On 04/04/2014 04:09 PM, Dan Williams wrote:
>  static void
>  device_removed_cb (NMDevice *device, gpointer user_data)
>  {
> -     remove_device (NM_MANAGER (user_data), device, FALSE);
> +     remove_device (NM_MANAGER (user_data), device, FALSE, "device request");
>  }

It might be better to add a reason string to the "removed" signal so
they can provide something more specific.

> +             remove_device (self, NM_DEVICE (iter->data), FALSE, "parent request");

That could also be clearer, maybe involving the parent ifname too.

-- Dan