Re: libgsystem as a git submodule, not system wide



On 02.04.2014 18:41, Thomas Haller wrote:
On Wed, 2014-04-02 at 14:03 +0200, poma wrote:
On 02.04.2014 11:05, Thomas Haller wrote:
Hi,

On Wed, 2014-04-02 at 06:32 +0200, poma wrote:
Why the 'libgsystem' is used as a git submodule, and not via the system
wide setup - 'libgsystem/devel'?

Because originally libgsystem was not available in distributions (or not
recent enough). That could be revised in the future, if it bothers
somebody enough.


I suppose this is the git way to acquire the source code to build a
local tarball,
git clone git://anongit.freedesktop.org/NetworkManager/NetworkManager
cd NetworkManager/
git submodule init
git submodule update
./autogen.sh
cd ../
tar ...


If you want to create a source tarball, a better way might be:

git clone git://anongit.freedesktop.org/NetworkManager/NetworkManager
cd NetworkManager/
./autogen.sh --enable-gtk-doc && make && make dist


I think, upstream creates it's tarball this way.




Perhaps this is the reason, however it is still a mystery why are
snapshots created with a blank 'libgsystem/'!?

I don't understand which snapshots you are referring to. If you do what
you said, you populate libgsystem/ before calling tar.



Thomas.


./autogen.sh --enable-gtk-doc
...
configure.ac:33: installing 'build-aux/missing'
automake: error: cannot open < libgsystem/Makefile-libgsystem.am: No
such file or directory
autoreconf: automake failed with exit status: 1

Snapshots/tarballs:
e.g.
http://cgit.freedesktop.org/NetworkManager/NetworkManager/
http://cgit.freedesktop.org/NetworkManager/NetworkManager/snapshot/NetworkManager-0.9.9.1.tar.gz
http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e9fdfa1
http://cgit.freedesktop.org/NetworkManager/NetworkManager/snapshot/NetworkManager-e9fdfa1.tar.gz
etc.


poma




The "snapshot" provided by the cgit webfrontend only gives you the
git-tree (but it does not include git-submodules). That is not really
the same as a source tarball (and as you experience it: it does not work
out of the box).

If you need a source tarball, create it with `make dist`, for which you
need a full git checkout. Or just use the git checkout directly.


Arguably, it should work just to take the snapshot. But with the
git-submodule that is not easy, because from the snapshot you loose the
information which commit of libgsystem you want to check out...


Thomas


Thanks for pointing out!


poma




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]