|
On Tuesday 03 of September 2013 16:57:05 Jiri Pirko wrote: > Signed-off-by: Jiri Pirko <jiri resnulli us> > --- > src/Makefile.am | 2 + > src/applet-device-team.c | 165 ++++++++++++++++ > src/applet-device-team.h | 27 +++ > src/applet.c | 12 ++ > src/applet.h | 1 + > src/connection-editor/Makefile.am | 6 + > src/connection-editor/ce-page-team-port.ui | 38 ++++ > src/connection-editor/ce-page-team.ui | 185 ++++++++++++++++++ > src/connection-editor/new-connection.c | 7 + > src/connection-editor/nm-connection-editor.c | 12 +- > src/connection-editor/nm-connection-list.c | 3 +- > src/connection-editor/page-team-port.c | 165 ++++++++++++++++ > src/connection-editor/page-team-port.h | 55 ++++++ > src/connection-editor/page-team.c | 269 >
It looks good to me. Just three things: 1. mnemonics keys (Alt-letter) in editor are not unique - see my attached patch 2. missing Team device handling in libnm-gtk - see my attached patch 3. I guess JSON config is the filename with the config data. In that case you should use file picker instead of simple text GtkEntry.
Jirka
PS: It seemed to me that I saw bond connection under team device in nm-applet. But, I have to test it once more.
|
Attachment:
0001-editor-use-unambiguous-mnemonic-kyes-for-Team-and-Te.patch
Description: Text Data
Attachment:
0002-libnm-gtk-recognize-Team-as-a-valid-virtual-device.patch
Description: Text Data