Re: [MM] [PATCH] novatel-lte: increase number of retries for connection status checks

[Ben Chan <benchan chromium org>]

60s seems a bit excessive as users most likely give up earlier.  Revised the patch to have a 30s timeout.

Thanks,

Ben

On Mon, May 27, 2013 at 12:52 AM, Aleksander Morgado <aleksander lanedo com> wrote:

On 26/05/13 08:45, Ben Chan wrote:
> This patch increases the number of retries, from 4 to 10, for connection
> status check during a connection / disconnection request, which handles
> some scenario when the connection / disconnection request takes more
> than 5 seconds to complete.

We recently updated most plugins and the generic implementation to wait
up to 60s to get the connection up. Do you really think that 10s is enough?

> ---
>  plugins/novatel/mm-broadband-bearer-novatel-lte.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/plugins/novatel/mm-broadband-bearer-novatel-lte.c b/plugins/novatel/mm-broadband-bearer-novatel-lte.c
> index 31c5650..677bc3c 100644
> --- a/plugins/novatel/mm-broadband-bearer-novatel-lte.c
> +++ b/plugins/novatel/mm-broadband-bearer-novatel-lte.c
> @@ -281,7 +281,7 @@ connect_3gpp (MMBroadbandBearer *self,
>                                               callback,
>                                               user_data,
>                                               connect_3gpp);
> -    ctx->retries = 4;
> +    ctx->retries = 10;
>
>      /* Get a 'net' data port */
>      ctx->data = "" (MM_BASE_MODEM (modem),
> @@ -333,7 +333,7 @@ detailed_disconnect_context_new (MMBroadbandBearer *self,
>                                               callback,
>                                               user_data,
>                                               detailed_disconnect_context_new);
> -    ctx->retries = 4;
> +    ctx->retries = 10;
>      return ctx;
>  }
>
>


--

Aleksander