Re: [PATCH] Add libgsystem as a git submodule



On Tuesday 21 of May 2013 11:07:02 Colin Walters wrote:
On Tue, 2013-05-21 at 09:08 +0200, Jirka Klimes wrote:
  CC     libgsystem_la-gsystem-file-utils.lo

libgsystem/gsystem-file-utils.c: In function 'linkcopy_internal_attempt':
libgsystem/gsystem-file-utils.c:358:3: error: implicit declaration of
function 'g_clear_pointer' [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors

Can you try with
https://git.gnome.org/browse/libgsystem/commit/?id=759384420c1578bf399473440
ab34af18fa46b8d

The patch misses terminating #endif:

diff --git a/gsystem-glib-compat.h b/gsystem-glib-compat.h
index edbdaab..70a9c1b 100644
--- a/gsystem-glib-compat.h
+++ b/gsystem-glib-compat.h
@@ -51,3 +51,4 @@ g_type_ensure (GType type)
 
 #endif
 
+#endif  /* __LIBGSYSTEM_GLIB_COMPAT__ */

Other than that it is good.

Thanks,
Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]