Re: [PATCH] dhclient: copy leasefiles from old location if needed (rh #916233)

On Thu, 2013-03-14 at 21:08 -0400, Colin Walters wrote:
On Thu, 2013-03-14 at 14:38 -0500, Dan Williams wrote:

+                                        error && error->message ? error->message : "(unknown)");

How could error be != NULL but error->message be NULL?  Sounds like
there was some buggy gobject library out there?  If so the right thing
is to fix it and not work around it everywhere...

It was because long ago, somebody complained that glibc or eglibc
crashed in *printf() if the string you passed was NULL.  Hence why that
check is sprinkled throughout code I've written.  I'm pretty sure that's
no longer the case, but it's kinda reflex by now.

If we agree that it's no longer a problem, I'm happy to stop doing
that :)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]