Re: [MM] [PATCH] iface-modem-3gpp: handle non-deferrable registration state updates

[Jiri Pirko <jiri resnulli us>]

Wed, Mar 06, 2013 at 09:35:03AM CET, aleksander lanedo com wrote:
> On 05/03/13 22:41, Dan Williams wrote:
> > On Tue, 2013-03-05 at 21:27 +0100, Jiri Pirko wrote:
> > > Tue, Mar 05, 2013 at 07:32:21PM CET, aleksander lanedo com wrote:
> > > > On 03/05/2013 03:37 AM, Ben Chan wrote:
> > > > > This patch changes MMIfaceModem3gpp to differentiate between deferrable
> > > > > and non-deferrable 3GPP registration state updates. Periodic or
> > > > > unsolicited registration state updates are deferrable, while internal
> > > > > updates, e.g. due to modem being disabled, are non-deferrable.
> > > > > ---
> > > > >  src/mm-iface-modem-3gpp.c | 40 ++++++++++++++++++++++------------------
> > > > >  1 file changed, 22 insertions(+), 18 deletions(-)
> > > >
> > > >
> > > > Pushed after some minor modifications.
> > >
> > > Sorry, I'm not sure I understand this correctly. Can you please tell be
> > > what does this message mean? Thanks.
> >
> > Usually whitespace fixes, slight style changes, or stuff like fixing a
> > missing free that shouldn't be a completely new commit, but aren't
> > enough to change attribution from the original submitter.
>
> In this specific case, it was just merging two nested if() plus changing
> the order of a condition in a third one.

I think its much cleaner to ask patch submitter to do such changes.
1) saves your work for next time
2) eliminates possibility of you introducing a bug and someone else will be
   "git blamed" for that.

I personally wouldn't like if my patch would be changed before apply.
Just my thoughts, nothing else.

Jiri

> -- 
> Aleksander