Re: [MM] [PATCH v2] iface-modem-3gpp: clear deferred registration state update when disabling

[Ben Chan <benchan chromium org>]

On Thu, Feb 28, 2013 at 11:46 PM, Aleksander Morgado <aleksander lanedo com> wrote:

On 02/28/2013 08:11 PM, Ben Chan wrote:
> ---
>  src/mm-iface-modem-3gpp.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>

I pushed it after modifying it to include the
clear_deferred_registration_state_update() call in the first
DISABLING_STEP_PERIODIC_REGISTRATION_CHECKS step. As said previously, we
don't really mind if we get an unsolicited registration event during the
disabling process, as we're disabling anyway.

I'm a bit confused. If an unsolicited registration event is received after clearing deferred_update_id, deferred_update_id is set to a new value, which will be scheduled after the modem is disabled. That will cause the modem state to become enabled due to the following code in mm-iface-modem-3gpp.c:

    mm_iface_modem_update_subsystem_state (
        MM_IFACE_MODEM (self),
        SUBSYSTEM_3GPP,
        (new_state == MM_MODEM_3GPP_REGISTRATION_STATE_SEARCHING ?
         MM_MODEM_STATE_SEARCHING :
         MM_MODEM_STATE_ENABLED),
        MM_MODEM_STATE_CHANGE_REASON_UNKNOWN);