Re: [MM] Question regarding minimum probing time in MMPluginManager
- From: Aleksander Morgado <aleksander lanedo com>
- To: Ben Chan <benchan chromium org>
- Cc: "networkmanager-list gnome org" <networkmanager-list gnome org>
- Subject: Re: [MM] Question regarding minimum probing time in MMPluginManager
- Date: Fri, 28 Jun 2013 09:13:42 +0200
The following code in MMPluginManager seems to always wait until the
minimum probing time is consumed.
/* If we didn't use the minimum probing time, wait for it to finish */
else if (ctx->timeout_id > 0) {
mm_dbg ("(Plugin Manager) '%s' port probe finished, last one
in device, "
"but minimum probing time not consumed yet ('%lf'
seconds elapsed)",
g_udev_device_get_name (port_probe_ctx->port),
g_timer_elapsed (ctx->timer, NULL));
For a modem with known port layout (assuming we have a way to specify
in the plugin), once all port probes finish, should MMPluginManager
proceed without waiting for the minimum probing time to expire? Is
there a potential downside? The obvious upside is cutting the modem
startup time.
This is just to let the kernel some time to expose all the ports, and
should only be a couple of seconds max. If the first probe is exposed
and right away probed, and there is no other port around when the
probing finishes, the whole device probing is assumed finished. Newer
ports appearing afterwards should still get grabbed by the already
created modem, but these ports will not take part in the probing
decisions. But of course, if we have a way to specify the expected port
layout in the plugin itself (in very device-specific plugins like the
novatel-lte or altair-lte), then there is no point in waiting the
minimum probing time if we already got the expected layout, of course.
--
Aleksander
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]