Re: [PATCH] nm-device: Remove bogus warning

[Colin Walters <walters verbum org>]

On Wed, 2013-06-19 at 08:11 -0500, Dan Williams wrote:

> It's more there because it's potentially a bug

Ok, the logic seems odd because we're doing effectively:

if (condition)
 {
   if (condition)
     warning ();
   deal_with_it ();
 }

If the code had looked like:

if (condition)
 {
   g_warn_if_reached ();
   deal_with_it ();
 }

it would have made more sense to me.

> What are you seeing it for?

It always fires for me starting NM git master in my Fedora 19 test VM;
it doesn't for you?