Re: [patch NetworkManager v3 0/6] add support for network team devices

[Dan Williams <dcbw redhat com>]

On Thu, 2013-07-25 at 15:36 +0200, Jiri Pirko wrote:
> I heavily reused existing code, mainly bonding parts. The only thing not
> implemented yet is dbus communication with teamd (used particulary for
> port config setup). That I want to add once this patchset gets applied.

Another good thing to do is some testcases for the ifcfg-rh plugin for
team masters and ports.  Can be done after too.  I've rebased the
patches onto git master (some of my changes last week in the ifcfg-rh
plugin conflicted) and pushed to the dcbw/team branch for the moment.

Thanks!
Dan

> v1->v2:
>  - rebased on current NM git
>  - removed "nm-setting-team.h" include from src/devices/nm-device-ethernet.c
>  - fixed typo TEAM_CONFIG -> TEAM_PORT_CONFIG  in write_team_port_setting()
>  - added "-n" option to teamd
> v2->v3:
>  - rebased on current NM git
>  - added dispose callback and calling team_cleanup from there
>  - ensure_killed uses GPOINTER_TO_INT (no need for extra structure)
>
> Jiri Pirko (6):
>   add support for team device
>   add setting for team port
>   ifcfg: add read support for team devices
>   ifcfg: add write support for team devices
>   cli: add team driver support
>   nm-device-team: spawn teamd for team device connection
>
>  cli/src/connections.c                  | 132 ++++++-
>  include/NetworkManager.h               |   3 +
>  introspection/Makefile.am              |   1 +
>  introspection/nm-device-team.xml       |  34 ++
>  libndp                                 |   2 +-
>  libnm-glib/Makefile.am                 |   2 +
>  libnm-glib/libnm-glib.ver              |   7 +
>  libnm-glib/nm-device-team.c            | 336 ++++++++++++++++++
>  libnm-glib/nm-device-team.h            |  82 +++++
>  libnm-glib/nm-device.c                 |   3 +
>  libnm-util/Makefile.am                 |   4 +
>  libnm-util/libnm-util.ver              |  11 +
>  libnm-util/nm-connection.c             |  34 ++
>  libnm-util/nm-connection.h             |   4 +
>  libnm-util/nm-setting-team-port.c      | 174 +++++++++
>  libnm-util/nm-setting-team-port.h      |  76 ++++
>  libnm-util/nm-setting-team.c           | 253 +++++++++++++
>  libnm-util/nm-setting-team.h           |  78 ++++
>  src/Makefile.am                        |   3 +
>  src/devices/nm-device-team.c           | 632 +++++++++++++++++++++++++++++++++
>  src/devices/nm-device-team.h           |  62 ++++
>  src/devices/nm-device.c                |  43 +--
>  src/logging/nm-logging.c               |   3 +-
>  src/logging/nm-logging.h               |   1 +
>  src/nm-activation-request.c            |   4 +-
>  src/nm-manager.c                       |  35 +-
>  src/settings/plugins/ifcfg-rh/reader.c | 163 ++++++++-
>  src/settings/plugins/ifcfg-rh/writer.c |  56 +++
>  28 files changed, 2173 insertions(+), 65 deletions(-)
>  create mode 100644 introspection/nm-device-team.xml
>  create mode 100644 libnm-glib/nm-device-team.c
>  create mode 100644 libnm-glib/nm-device-team.h
>  create mode 100644 libnm-util/nm-setting-team-port.c
>  create mode 100644 libnm-util/nm-setting-team-port.h
>  create mode 100644 libnm-util/nm-setting-team.c
>  create mode 100644 libnm-util/nm-setting-team.h
>  create mode 100644 src/devices/nm-device-team.c
>  create mode 100644 src/devices/nm-device-team.h