Re: [MM] [PATCH] iface-modem-3gpp: clear deferred registration state update when disabling
- From: Aleksander Morgado <aleksander lanedo com>
- To: Ben Chan <benchan chromium org>
- Cc: networkmanager-list gnome org
- Subject: Re: [MM] [PATCH] iface-modem-3gpp: clear deferred registration state update when disabling
- Date: Thu, 28 Feb 2013 12:51:27 +0100
When I reviewed your original patch I actually checked for when we were
removing the timeout when disabling, and assumed it was done when we set
the GObject's data to NULL, but I mixed the two data objects we handle
here, as one of them (the one where this new timeout id is stored) isn't
removed during disabling. So, yes, we need this method to remove the
timeout. Now, I would add the clearing method just when we start the
disabling sequence, next to the periodic_registration_check_disable()
call. Or was it added in CLEANUP_UNSOLICITED_REGISTRATION_EVENTS for
some reason?
Could an unsolicited registration state update happen between
invocations of interface_disabling_step()? I was wondering if the
deferred_update_id should be cleared after unsolicited registration
event handling is removed.
It could, yes, but we wouldn't really care as we're disabling anyway.
--
Aleksander
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]