Re: [PATCH 0/2] Fix default-duid support
- From: Gene Czarcinski <gene czarc net>
- To: NetworkManager mailing list <networkmanager-list gnome org>
- Subject: Re: [PATCH 0/2] Fix default-duid support
- Date: Wed, 13 Feb 2013 03:18:03 -0500
On 02/13/2013 03:01 AM, Gene Czarcinski wrote:
These two patches correct the code for default-duid support.
The first patch changes the code so that a default-duid is
gotten from the lease file, from one of the system files such as
/etc/dhclient6.leases, or a generate duid-UUID based on the
machine-id.
The second patch adds the routine machine_id_parse() and uses it
in place of uuid_parse(). The machine-id "uuid" is not compatable
with standard uuid.
Gene Czarcinski (2):
save duid to lease file
add special machine-id parse function
src/dhcp-manager/nm-dhcp-client.c | 30 +++++++++++++++++++++++++++++-
src/dhcp-manager/nm-dhcp-dhclient.c | 24 +++++++++++++++++++++---
2 files changed, 50 insertions(+), 4 deletions(-)
This is based on git 0.9.7.997 but appears to apply to master also.
Besides duid-UUID now working, I tested getting a sysadmin specified
default-duid
from /etc/dhclient6.leases, /var/lib/dhcp/dhclient6.leases,
/var/lib/dhclient/dhclient6.leases,
or from the NetworkManger connection-specific lease file.
I suggest this be applied before releasing 0.9.8.0.
I rebased to nm-0-9-8 with no problems or corrections needed.
Gene
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]