Re: [PATCH 2/5] connectivity: Add libxml2 as a dependency
- From: Dan Williams <dcbw redhat com>
- To: Jonh Wendell <jonh wendell gmail com>
- Cc: networkmanager-list gnome org
- Subject: Re: [PATCH 2/5] connectivity: Add libxml2 as a dependency
- Date: Mon, 11 Feb 2013 11:35:14 -0600
On Mon, 2013-02-11 at 15:30 -0200, Jonh Wendell wrote:
> In these patches I want to fix the 511-http-status. As it's something
> new, of course most hotspots don't use that (including my employer).
>
> Almost all of them rely on 30X Moved with help of the Wispr
> 'pseudo-protocol'. It's on my TODO list to work on those scenarios.
> That would touch only code in NMConnectivity object.
>
>
> Indeed, for that cases, we would use xml parsing as wispr is xml.
Thanks for the clarification. In any case, would a regex be possible
here instead of the XML for now? It might be less code and would
certainly be less error-prone when checking broken HTML which is quite
common.
Dan
>
>
> 2013/2/11 Dan Williams <dcbw redhat com>
> On Mon, 2013-02-11 at 17:10 +0100, Bastien Nocera wrote:
> > On Mon, 2013-02-11 at 10:06 -0600, Dan Williams wrote:
> > > On Mon, 2013-02-11 at 12:09 -0200, Jonh Wendell wrote:
> > > > From: Jonh Wendell <jonh wendell oiwifi com br>
> > > >
> > > > libsoup already depends on libxml2 but we need to
> explicitly link
> > > > to it.
> > >
> > > At least we already theoretically required it; though is
> it possible to
> > > use GMarkup here instead of libxml2? GMarkup would be
> somewhat simpler,
> > > though it's only a subset.
> >
> > Given how it's used, there's probably little reason this
> couldn't be a
> > regexp. Both GMarkup and libxml2 would choke on broken,
> slightly broken,
> > and very very broken HTML files.
>
>
> Yeah, and I've heard that for example, some hotspots literally
> just
> append raw XML to the end of the HTTP request outside the
> XML. I think
> we need to be somewhat more robust here and XML parsing may
> not be the
> way to get there? Also, we may need to add special cases for
> various
> hotspots, which might require regex and not just XML parsing.
>
> Dan
>
>
>
>
> --
> Jonh Wendell
> http://www.bani.com.br
>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]